-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Support [tool:pytest] in setup.cfg files #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| * ``[pytest]`` sections in ``setup.cfg`` files should now be named ``[tool:pytest]`` | ||
| to avoid conflicts with other distutils commands (see `#567`_). ``[pytest]`` in | ||
| ``pytest.ini`` or ``tox.ini`` files are supported and unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (feel free to ignore): "[pytest] sections in ...." or "is supported"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks, it is better really.
|
while we are at it, we might want to support |
Also deprecate [pytest] usage in setup.cfg files Fix pytest-dev#567
b792384 to
ab86dea
Compare
Not sure @RonnyPfannschmidt... I consider supporting If we add the same support to |
|
main reason im proposing it, is to set a stage - after all pytest.ini we own, but tox.ini is owned by tox and setup.cfg is owned by distutils |
|
I see. But perhaps we should do it in a separate issue/PR? It's just that I would not like to rush this in without some discussion, perhaps involving more people. |
|
good point - the tox ini handling can be deffered to a later release in any case |
|
Anything else? Can we merge this? |
|
Thanks! 😁 |
|
👍 great job |
Also deprecate
[pytest]usage insetup.cfgfilesFix #567